From 0de9a6205844f64bec727cbd8154f1667e8c6f16 Mon Sep 17 00:00:00 2001
From: dadaloop82 <evershelfproject@gmail.com>
Date: Thu, 7 May 2026 17:38:05 +0000
Subject: [PATCH] fix: price estimate for all items, including manually-added
 ones
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- AI prompt: always return a best-guess price (never null/price_not_found)
  for unrecognised items returns generic package estimate with '~' prefix
- Cache key bumped to v3 to invalidate old null-returning cache entries
- JS: manually-added items (no smart match, no spec) default to qty=1/conf
  instead of qty=1/pz so _calcEstimatedTotal treats them as a single pack
- Price badge: shows '~€X.XX' prefix when source_note starts with '~'
  so user knows the price is a rough estimate
---
 api/index.php    | 16 +++++++++-------
 assets/js/app.js | 13 ++++++++++---
 2 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/api/index.php b/api/index.php
index cda3fb9..92599c1 100644
--- a/api/index.php
+++ b/api/index.php
@@ -6488,7 +6488,7 @@ function _savePriceCache(array $data): void {
  * Bump version suffix when AI prompt format changes to auto-invalidate old entries.
  */
 function _priceKey(string $name, string $country): string {
-    return md5(mb_strtolower(trim($name)) . '|' . mb_strtolower(trim($country)) . '|v2');
+    return md5(mb_strtolower(trim($name)) . '|' . mb_strtolower(trim($country)) . '|v3');
 }
 
 /**
@@ -6505,20 +6505,22 @@ function _fetchPriceFromAI(string $name, string $country, string $currency, stri
     $prompt = <<<PROMPT
 You are a grocery price assistant. Estimate the typical retail price for "{$name}" in {$country}, currency {$currency}.
 
-Return the price for the MOST NATURAL RETAIL UNIT — that is, the smallest standard unit a shopper would actually buy:
-- Products in standard packages (pasta, flour, frozen food, yogurt, canned goods): price per typical package (e.g. "pacco 500g", "barattolo 400g", "confezione")
-- Products sold by the piece or bunch (fresh herbs, eggs, individual fruits/vegetables, single portions): price per piece/bunch (e.g. "mazzo", "uovo", "pz")
+Return the price for the MOST NATURAL RETAIL UNIT — the smallest standard unit a shopper would actually buy:
+- Standard packages (pasta, flour, frozen food, yogurt, canned goods, biscuits): price per typical package (e.g. "pacco 500g", "barattolo 400g", "confezione")
+- Sold by piece or bunch (fresh herbs, eggs, individual fruit/vegetables, single portions): price per piece/bunch (e.g. "mazzo", "uovo", "pz")
 - Liquids in bottles or cartons: price per typical container (e.g. "bottiglia 1L", "brick 1L")
-- Deli counter items sold loose by weight (prosciutto, salami, fresh fish): price per kg
+- Deli items sold loose by weight: price per kg
 
 Rules:
 1. Use mid-range supermarket prices (not premium, not discount).
 2. Round to 2 decimal places.
 3. NEVER return per-kg for items normally sold in packages or by the piece.
-4. Respond ONLY with valid JSON — no markdown, no explanation:
+4. ALWAYS return your best estimate — even for generic or unusual items. Use a typical grocery item if uncertain.
+5. Respond ONLY with valid JSON — no markdown, no explanation:
 {"price_per_unit": 1.50, "unit_label": "mazzo", "currency": "{$currency}", "source_note": "Basilico fresco ~€1.50/mazzo in {$country}"}
 
-If truly unknown, return: {"price_per_unit": null, "unit_label": null, "currency": "{$currency}", "source_note": "prezzo non disponibile"}
+If you are genuinely unsure, return a rough estimate for 1 typical package with a "~" in source_note:
+{"price_per_unit": 2.00, "unit_label": "confezione", "currency": "{$currency}", "source_note": "~ stima generica confezione in {$country}"}
 PROMPT;
 
     $payload = ['contents' => [['parts' => [['text' => $prompt]]]]];
diff --git a/assets/js/app.js b/assets/js/app.js
index 7f600fd..8f4fedc 100644
--- a/assets/js/app.js
+++ b/assets/js/app.js
@@ -8772,6 +8772,11 @@ function _buildPricePayload() {
             if (qtyMatch) {
                 quantity = parseFloat(qtyMatch[1].replace(',', '.'));
                 unit = qtyMatch[2].toLowerCase();
+            } else {
+                // Manually-added item with no spec: assume 1 confezione
+                // (most grocery items are bought as a single pack)
+                quantity = 1;
+                unit = 'conf';
             }
         }
 
@@ -8785,9 +8790,11 @@ function _buildPricePayload() {
  * @param {string} sym    — currency symbol like "€"
  */
 function _buildPriceBadgeHTML(entry, sym) {
-    const mainLabel = entry.estimated_total != null
-        ? `${sym}${entry.estimated_total.toFixed(2)}`
-        : `${sym}${entry.price_per_unit.toFixed(2)}`;
+    const isApprox = (entry.source_note || '').startsWith('~');
+    const mainLabel = (isApprox ? '~' : '')
+        + (entry.estimated_total != null
+            ? `${sym}${entry.estimated_total.toFixed(2)}`
+            : `${sym}${entry.price_per_unit.toFixed(2)}`);
     const unitLabel = entry.unit_label || '';
     const unitLine = unitLabel && entry.price_per_unit != null
         ? `${sym}${entry.price_per_unit.toFixed(2)}/${unitLabel}`