From d9602df3c38ed89358a444e6816d436634fbbcde Mon Sep 17 00:00:00 2001 From: dadaloop82 Date: Mon, 4 May 2026 16:35:54 +0000 Subject: [PATCH] fix(settings): ReferenceError s not defined in _populateLanguageSelector Screensaver toggle init was incorrectly placed inside _populateLanguageSelector() where 's' (getSettings()) is not in scope. Moved to loadSettingsUI() alongside the other preference checkboxes where 's = getSettings()' is already defined. --- assets/js/app.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/assets/js/app.js b/assets/js/app.js index bc43093..69a682e 100644 --- a/assets/js/app.js +++ b/assets/js/app.js @@ -1101,9 +1101,6 @@ function translatePage() { // Populate the language selector dropdown function _populateLanguageSelector() { const sel = document.getElementById('setting-language'); - // Screensaver toggle - const ssEl = document.getElementById('setting-screensaver-enabled'); - if (ssEl) ssEl.checked = s.screensaver_enabled === true; if (!sel) return; sel.innerHTML = ''; for (const [code, name] of Object.entries(_SUPPORTED_LANGS)) { @@ -1868,6 +1865,8 @@ async function loadSettingsUI() { document.getElementById('setting-pref-healthy').checked = !!s.pref_healthy; document.getElementById('setting-pref-opened').checked = !!s.pref_opened; document.getElementById('setting-pref-zerowaste').checked = !!s.pref_zerowaste; + const ssEl = document.getElementById('setting-screensaver-enabled'); + if (ssEl) ssEl.checked = s.screensaver_enabled === true; document.getElementById('setting-dietary').value = s.dietary || ''; // Camera const cameraSelect = document.getElementById('setting-camera-facing');