fix: drastically reduce false-positive consumption anomaly banners

Two changes:
1. Skip prediction when expected_qty=0 — model says 'should be finished'
   but user simply restocked or consumed less. Not actionable.
2. Raise 'more than expected' threshold to 400% (was 30%).
   Having more than expected almost always means a restock the model
   doesn't know about yet — only truly extreme cases (>4x) are flagged.
   'Less than expected' stays at 30% (still actionable: unregistered use).
This commit is contained in:
dadaloop82
2026-05-11 17:31:41 +00:00
parent 5b401f8d5f
commit cb39b63997
2 changed files with 15 additions and 3 deletions
+13 -1
View File
@@ -2166,9 +2166,21 @@ function getConsumptionPredictions(PDO $db): void {
// Flag if deviation > 30% and absolute diff > meaningful threshold
$deviation = abs($actualQty - $expectedQty);
$threshold = max($dailyRate * 3, 0.5); // at least 3 days worth or 0.5 units
// If expected = 0 and actual > 0, the model simply thinks the product
// should have been used up by now. This is NOT an anomaly — the user
// either restocked (not yet tracked) or consumed less than usual.
// Only flag "less" direction when expected = 0 (actual ran out faster).
if ($expectedQty <= 0 && $actualQty >= 0) continue;
$pctDev = $expectedQty > 0 ? ($deviation / $expectedQty) : ($actualQty > 0 ? 1 : 0);
if ($pctDev > 0.30 && $deviation > $threshold) {
// "more than expected" is almost always a restock the model doesn't know about yet.
// Only flag it at very high deviation (>400%) to catch truly impossible values.
// "less than expected" is more actionable: user may have consumed without registering.
$flagThreshold = ($actualQty > $expectedQty) ? 4.0 : 0.30;
if ($pctDev > $flagThreshold && $deviation > $threshold) {
$unit = $item['unit'];
// Format expected/actual in human units
if ($unit === 'conf' && $item['default_quantity'] > 0 && $item['package_unit']) {