morgane/EverShelf
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

fix(settings): ReferenceError s not defined in _populateLanguageSelector

Browse Source 
Screensaver toggle init was incorrectly placed inside _populateLanguageSelector()
where 's' (getSettings()) is not in scope. Moved to loadSettingsUI() alongside
the other preference checkboxes where 's = getSettings()' is already defined.
This commit is contained in:
dadaloop82
2026-05-04 16:35:54 +00:00
parent 1fb00d48a9
commit d9602df3c3
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/js/app.js
+2 -3
View File
@@ -1101,9 +1101,6 @@ function translatePage() {
// Populate the language selector dropdown // Populate the language selector dropdown
function _populateLanguageSelector() { function _populateLanguageSelector() {
const sel = document.getElementById('setting-language'); const sel = document.getElementById('setting-language');
// Screensaver toggle
const ssEl = document.getElementById('setting-screensaver-enabled');
if (ssEl) ssEl.checked = s.screensaver_enabled === true;
if (!sel) return; if (!sel) return;
sel.innerHTML = ''; sel.innerHTML = '';
for (const [code, name] of Object.entries(_SUPPORTED_LANGS)) { for (const [code, name] of Object.entries(_SUPPORTED_LANGS)) {
@@ -1868,6 +1865,8 @@ async function loadSettingsUI() {
document.getElementById('setting-pref-healthy').checked = !!s.pref_healthy; document.getElementById('setting-pref-healthy').checked = !!s.pref_healthy;
document.getElementById('setting-pref-opened').checked = !!s.pref_opened; document.getElementById('setting-pref-opened').checked = !!s.pref_opened;
document.getElementById('setting-pref-zerowaste').checked = !!s.pref_zerowaste; document.getElementById('setting-pref-zerowaste').checked = !!s.pref_zerowaste;
const ssEl = document.getElementById('setting-screensaver-enabled');
if (ssEl) ssEl.checked = s.screensaver_enabled === true;
document.getElementById('setting-dietary').value = s.dietary || ''; document.getElementById('setting-dietary').value = s.dietary || '';
// Camera // Camera
const cameraSelect = document.getElementById('setting-camera-facing'); const cameraSelect = document.getElementById('setting-camera-facing');